-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Could importing asyncio optional? #765
Comments
Can we also look at exempting the Py3 only .py files from the Py2 wheel? When I build pex's I also compile all I can have a go at a PR - Anyone got good ideas about how to do this? |
Including Py3 only source in universal wheel or source package is very common. Anyway, it's not relating to this issue. |
This had been discussed multiple times. I'm on my phone, so can't link right now. Our stance is that if a build tool fails on files that won't be imported on unsupported versions, it's the build tool that needs to be fixed. |
After #731 is merged, importing jinja2 on Python 3 get dramatically faster.
For now, over 40% of import time is caused by asyncio support.
(See this gist for detail)
Jinja2's document says:
But even when user doesn't use async support,
jinja2.asyncsupport
is imported:jinja/jinja2/__init__.py
Lines 74 to 82 in b73cb48
Would you make importing asyncio optional to improve import time of jinja2?
For example, faster import time is beneficial on GAE/Python.
And less import means less memory footprint too.
The text was updated successfully, but these errors were encountered: