Change migrations to be transactional #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -356,13 +368,8 @@ def execute_migrations(self, show_traceback=True): | |||
| database=db, | |||
| ) | |||
| except Exception: | |||
| transaction.rollback(using=db) | |||
| sys.stdout.write("Rolled back all migrations on %r.\n" % db) | |||
There was a problem hiding this comment.
actually this comment is now incorrect and I need to update it
|
Everything should be good now. |
|
@dcramer excellent. @brosner and I have talked about going back to original model of nashvegas where each migration was executed in it's own transaction. this looks more elegant than the original solution and am excited to dig in to this for a deeper review before merging this in. thanks for all your contributions to nashvegas! |
paltman
added a commit
that referenced
this pull request
Apr 7, 2012
Change migrations to be transactional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects some weird behavior we've seen by only running transactions on the current database. I know we briefly talked about transactions, but I want to confirm there are actual issues where migration A should rely on migration B, as that doesnt really seem like great design.
Specifically, each migration is run in its own transaction, and then syncdb is run, all within the single transaction. THis is committed and the next migration is run. Once all migrations are run on a database, it will run the loaddata command.