Changed unsigned int to signed int for resync in DistributedSmoothNode. #1162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
The current code in
direct.dc
is as follows:suggestResync
is called in the method forDistributedSmoothNode#setComponentTLive
, whereuncertainty = globalClockDelta.getUncertainty()
. The definition forClockDelta.getUncertainty()
states:Therefore, the return value can be either positive or negative. This is exemplified by the following exception trace, where
getUncertainty
happened to return a negative value:Since the associated method
returnResync
is called on the other party with the same value of the parameteruncertainty
, fixing both is necessary to correct this issue.Solution description
To fix this issue, the value of
uncertainty
should be a signed integer, since the documentation for the values it can take on indicate that it can be negative.Checklist
I have done my best to ensure that…