Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS path to /Library/Developer #782

Closed
wants to merge 2 commits into from
Closed

Update macOS path to /Library/Developer #782

wants to merge 2 commits into from

Conversation

0And
Copy link

@0And 0And commented Nov 11, 2019

I changed the mac path to /Library/Developer and updated the macOS xcode-tools path. This should fix issue #760

@el-dee
Copy link
Contributor

el-dee commented Nov 12, 2019

I'm wondering if the old installation of Panda in /Developer should be removed by the installation script, otherwise we will end up with two installation of Panda on non-Catalina machines.

@0And
Copy link
Author

0And commented Nov 14, 2019

You're right about that.
Also, here is documentation on Apple's file system if anyone is wondering: https://developer.apple.com/library/archive/documentation/FileManagement/Conceptual/FileSystemProgrammingGuide/FileSystemOverview/FileSystemOverview.html
The /Library/Developer directory seems to be the new corresponding place for the previous /Developer directory.

@0And 0And closed this Nov 14, 2019
@el-dee
Copy link
Contributor

el-dee commented Nov 14, 2019

Moving to /Library/Developer is a good short term compromise, but I still believe the long term solution would be to make Panda3d a Framework, /Library/Developer is not really documented and mainly used by the command line tools of Xcode. On the other hand, Frameworks are documented properly by Apple and many if not all libraires and SDKs are shipped as frameworks.

That said, there is much more work to do to transform the Panda SDK into a Framework as the layout will need to be changed to conform to Apple requirements. And there might be a heavier impact on existing application (but that is to be confirmed)

@rdb
Copy link
Member

rdb commented Dec 4, 2019

I see that this was closed and I cannot reopen it because the original branch was deleted; can we still apply this for 1.10.5, since we likely will not be ready to apply the framework solution in the short term?

@el-dee
Copy link
Contributor

el-dee commented Dec 4, 2019

Since there will be two builds, one for older MacOS and one for Catalina, wouldn't it be better to still target /Developer if we are doing a build for Mac <= Mojave and target /Library/Developer for Catalina ?

Doing so would avoid to try and detect a previous installation in /Developer and delete it on older version, and on Catalina there would be no migration as /Developer can not exist.

@rdb
Copy link
Member

rdb commented Dec 4, 2019

My reasoning for making a second build that targeted 10.9+ (instead of 10.15+) is that we would kill two birds with one stone, by making the second build compiled with libc++.

However, your reasoning does make sense as well, and it's easier to separate out the two cases in makepanda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants