Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PF Met from re-miniAOD #10

Closed
blallen opened this issue Mar 22, 2017 · 9 comments
Closed

Fix PF Met from re-miniAOD #10

blallen opened this issue Mar 22, 2017 · 9 comments

Comments

@blallen
Copy link
Collaborator

blallen commented Mar 22, 2017

PF Met taken out of the box from the re-miniAOD is broken. We can either run an official CMS producer from Zeynep or we can add Sid's private fix, but we should fix this for version 003 so we don't need to run it on top of panda anymore.

@sidnarayanan
Copy link
Collaborator

Private fix doesn't work perfectly since PF and SC matching doesn't seem to always work. Let's do it properly:

https://twiki.cern.ch/twiki/bin/view/CMSPublic/ReMiniAOD03Feb2017Notes#MET_Recipes

@sidnarayanan
Copy link
Collaborator

One thing to note here: the PF candidates from the fix have to be fed back into puppi and fatjets

@yiiyama
Copy link
Collaborator

yiiyama commented Mar 30, 2017

If you are talking about applying the fix on PF candidates from the bad muon removal to MC, it is propagated everywhere.
https://github.com/PandaPhysics/PandaProd/blob/master/Producer/cfg/prod.py#L369-L372
These lines go into the analyzer and producer configs and replace packedPFCandidates with cleanMuonsPFCandidates.

@sidnarayanan
Copy link
Collaborator

No, I was referring to propagating the EG correction back to PF level. Related: right now we set electron pfPt by looking for a PF cand that is an electron, but sometimes it's a photon at pf level (and vice versa). Could we make it an OR of the PF IDs?

@yiiyama
Copy link
Collaborator

yiiyama commented Mar 30, 2017

Yes, that came up with Brandon too. One of my PRs do that - I forgot which..

@yiiyama
Copy link
Collaborator

yiiyama commented Mar 30, 2017

But I thought we don't apply EG correction to PF candidates? CMSSW recipe is to correct just the MET, no?

@yiiyama
Copy link
Collaborator

yiiyama commented Mar 30, 2017

PandaPhysics/PandaProd#6

This does not include fix on PF candidates though, if we want to do that.

@sidnarayanan
Copy link
Collaborator

Sorry, that was my mistake. We indeed don't want to propagate things to PF candidate level. PandaPhysics/PandaProd#6 looks good to me

@yiiyama yiiyama closed this as completed Apr 7, 2017
@yiiyama yiiyama reopened this Apr 11, 2017
@yiiyama
Copy link
Collaborator

yiiyama commented Apr 11, 2017

Sid is seeing discrepancies between nero and panda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants