Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add genDict to PandaTree #74

Closed
yiiyama opened this issue Jul 11, 2017 · 5 comments
Closed

Add genDict to PandaTree #74

yiiyama opened this issue Jul 11, 2017 · 5 comments
Assignees

Comments

@yiiyama
Copy link
Collaborator

yiiyama commented Jul 11, 2017

Hey @sidnarayanan can you add your upgraded genDict script to PandaTree? We've already put the LinkDef and related files in the dict/ directory of Framework and Objects, and there isn't really a reason not to support CLING with Panda.

@sidnarayanan
Copy link
Collaborator

Since there's only one LinkDef for each of Framework and Objects, could we move them to the top-level (e.g. Framework/LinkDef.h)? This would keep it consistent my other packages.

@sidnarayanan
Copy link
Collaborator

For reference, here's my upgraded script: https://github.com/sidnarayanan/PandaCore/blob/dev-submission/bin/genDict

It searches for anything in $CMSSW_BASE/src/*/*/LinkDef.h

@yiiyama
Copy link
Collaborator Author

yiiyama commented Jul 11, 2017

Fine with me! Please do whatever you see fit.

@yiiyama
Copy link
Collaborator Author

yiiyama commented Aug 27, 2017

I'm going to temporarily package genDict with PandaTree, but maybe having PandaCore (assuming the dev-submission branch is not abandoned) as a standard installation in PandaPhysics is a better solution.

@yiiyama yiiyama closed this as completed Aug 27, 2017
@sidnarayanan
Copy link
Collaborator

I hadn't yet acted on this issue because Dylan reported some issues when using genDict with PandaTree, which I hadn't looked into yet. I guess for now it can be use-at-your-own-risk.

The dev-submission branch is not abandoned - actually it is the primary branch but I don't have it merged to master yet because of a couple outstanding issues. On the other hand, PandaCore contains a lot of stuff the average user won't need - I think I'm the only one who uses the plotting framework, e.g. Let's discuss this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants