Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important HLTBits bug #88

Closed
sidnarayanan opened this issue Aug 31, 2017 · 3 comments
Closed

Important HLTBits bug #88

sidnarayanan opened this issue Aug 31, 2017 · 3 comments
Labels

Comments

@sidnarayanan
Copy link
Collaborator

I found that the prod-004 tag of PandaTree was reading triggers incorrectly in 004 files. I found a number of events in which the trigger should have fired, but was not picked up as such (weirdly enough it was firing a different trigger...might be the 32/64 bit issue?). Anyway, I reverted to a branch that I knew worked [1]. Will investigate this later (this was discovered trying to do some last-minute studies), but this needs to be understood and properly tagged.

[1] https://github.com/sidnarayanan/PandaTree/tree/testing-hlt

@yiiyama
Copy link
Collaborator

yiiyama commented Sep 21, 2017

There was a bug in tree transition that was fixed by a later commit in branch-004. I'd say we should delete the current prod-004 tag and re-tag the HEAD of the branch. What do you think?

@sidnarayanan
Copy link
Collaborator Author

Ah yes sorry, that was on me to do, and I forgot. Will take care of it today.

@yiiyama
Copy link
Collaborator

yiiyama commented Nov 11, 2017

I moved the prod-004 tag to the current master of branch-004.

@yiiyama yiiyama closed this as completed Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants