Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERR: raise NotImplemented error if keywords are passed to read_excel which are not supported #11544

Closed
jreback opened this issue Nov 7, 2015 · 3 comments
Closed

ERR: raise NotImplemented error if keywords are passed to read_excel which are not supported #11544

jreback opened this issue Nov 7, 2015 · 3 comments
Labels
Error Reporting Incorrect or improved errors from pandas IO Excel read_excel, to_excel
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Nov 7, 2015

xref #11527
xref #10001

currently we pass thru keywords to the TextReader but some of these don't do anything. Should catch and raise on these.
@jreback jreback added Difficulty Novice Error Reporting Incorrect or improved errors from pandas IO Excel read_excel, to_excel labels Nov 7, 2015
@jreback jreback added this to the Next Major Release milestone Nov 7, 2015
@grahamjeffries grahamjeffries mentioned this issue Dec 19, 2015
Merged
@jreback jreback modified the milestones: 0.18.0, Next Major Release Dec 19, 2015
jreback added a commit that referenced this issue Dec 19, 2015
@jreback
Merge pull request #11870 from grahamjeffries/bugfix-11544
a050a33 
raise NotImplemented for date parsing args in read_excel #11544
@jorisvandenbossche
Copy link
Member

Did #11870 close this fully? There are not other keywords that also should raise?

@jreback
Copy link
Contributor Author

jreback commented Dec 23, 2015

I think we need to change read_excel to have explict keywords, maybe 'accepting' some common ones where we raise NotImplementedError to give a nicer error messsage.

so let's reopen this one.

@jreback jreback reopened this Dec 23, 2015
@jreback
Copy link
Contributor Author

jreback commented Dec 23, 2015

cc @grahamjeffries

@grahamjeffries grahamjeffries mentioned this issue Jan 15, 2016
Closed
@jreback jreback modified the milestones: 0.18.1, 0.18.0 Feb 9, 2016
@jreback jreback mentioned this issue Mar 2, 2016
Closed
@jreback jreback changed the title ERR: raise NotImplemented error if keywords are passed to read_excel which are not supported ERR: raise NotImplemented error if keywords are passed to read_excel which are not supported Mar 2, 2016
@jreback jreback mentioned this issue Mar 21, 2016
Closed
@jreback jreback mentioned this issue Mar 29, 2016
Closed
@jreback jreback modified the milestones: 0.18.2, 0.18.1 Apr 25, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.0 Aug 21, 2016
jorisvandenbossche pushed a commit that referenced this issue Sep 30, 2016
@grahamjeffries @jorisvandenbossche
remove read_excel kwd NotImplemented error, update documentation #11544
e3ec250
jorisvandenbossche pushed a commit that referenced this issue Sep 30, 2016
@grahamjeffries @jorisvandenbossche
remove read_excel kwd NotImplemented error, update documentation #11544
0e10a9d
jreback pushed a commit to jreback/pandas that referenced this issue Mar 27, 2017
@jorisvandenbossche @jreback
Remove NotImplementedError for parse_dates keyword in read_excel
10d8c40 
Rebase and update of PR pandas-dev#12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes pandas-dev#14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation pandas-dev#11544
@jreback jreback mentioned this issue Mar 27, 2017
Closed
jreback pushed a commit that referenced this issue Mar 27, 2017
@grahamjeffries @jreback
Remove NotImplementedError for parse_dates keyword in read_excel
b36a461 
Rebase and update of PR #12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
jreback pushed a commit that referenced this issue Mar 27, 2017
@grahamjeffries @jreback
Remove NotImplementedError for parse_dates keyword in read_excel
7e43c78 
Rebase and update of PR #12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
mattip pushed a commit to mattip/pandas that referenced this issue Apr 3, 2017
@grahamjeffries @mattip
Remove NotImplementedError for parse_dates keyword in read_excel
40b4e24 
Rebase and update of PR pandas-dev#12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes pandas-dev#14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation pandas-dev#11544
mattip pushed a commit to mattip/pandas that referenced this issue Apr 3, 2017
@jreback @mattip
BUG: index_names can be None when processing date conversions
f0c3954 
closes pandas-dev#15820
closes pandas-dev#11544
@WillAyd WillAyd mentioned this issue Dec 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas IO Excel read_excel, to_excel
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

Remove NotImplementedError for parse_dates keyword in read_excel pandas-dev/pandas
2 participants
@jreback @jorisvandenbossche