/pandas

New issue

ERR: raise NotImplemented error if keywords are passed to read_excel which are not supported #11544

Closed
jreback opened this Issue Nov 7, 2015 · 3 comments

Comments

Assignees
No one assigned
Labels
Difficulty Novice Effort Low Error Reporting IO Excel
Projects
None yet
Milestone
  0.20.0
2 participants
@jreback @jorisvandenbossche
@jreback
Contributor

jreback commented Nov 7, 2015

xref #11527
xref #10001

currently we pass thru keywords to the TextReader but some of these don't do anything. Should catch and raise on these.

@jreback jreback added Difficulty Novice Error Reporting IO Excel Effort Low labels Nov 7, 2015

jreback added this to the Next Major Release milestone Nov 7, 2015

grahamjeffries referenced this issue Dec 19, 2015

Merged

raise NotImplemented for date parsing args in read_excel #11544 #11870

@jreback jreback modified the milestone: 0.18.0, Next Major Release Dec 19, 2015

jreback closed this in #11870 Dec 19, 2015

@jreback jreback added a commit that referenced this issue Dec 19, 2015

@jreback jreback Merge pull request #11870 from grahamjeffries/bugfix-11544 
raise NotImplemented for date parsing args in read_excel #11544
 a050a33
@jorisvandenbossche
Owner

jorisvandenbossche commented Dec 22, 2015

Did #11870 close this fully? There are not other keywords that also should raise?
@jreback
Contributor

jreback commented Dec 23, 2015

I think we need to change read_excel to have explict keywords, maybe 'accepting' some common ones where we raise NotImplementedError to give a nicer error messsage.

so let's reopen this one.

jreback reopened this Dec 23, 2015

@jreback
Contributor

jreback commented Dec 23, 2015

cc @grahamjeffries

grahamjeffries referenced this issue Jan 15, 2016

Closed

remove read_excel keyword NotImplemented error, update documentation #11544 #12051

@jreback jreback modified the milestone: 0.18.1, 0.18.0 Feb 9, 2016

jreback referenced this issue Mar 2, 2016

Closed

read_excel allows invalid kwargs #12507

jreback changed the title from ERR: raise NotImplemented error if keywords are passed to ``read_excel`` which are not supported to ERR: raise NotImplemented error if keywords are passed to read_excel which are not supported Mar 2, 2016

This was referenced Mar 21, 2016

Closed
Closed

@jreback jreback modified the milestone: 0.18.2, 0.18.1 Apr 25, 2016

@jorisvandenbossche jorisvandenbossche modified the milestone: 0.20.0, 0.19.0 Aug 21, 2016

@jorisvandenbossche jorisvandenbossche added a commit that referenced this issue Sep 30, 2016

@grahamjeffries @jorisvandenbossche grahamjeffries + jorisvandenbossche remove read_excel kwd NotImplemented error, update documentation #11544 e3ec250

@jorisvandenbossche jorisvandenbossche added a commit that referenced this issue Sep 30, 2016

@grahamjeffries @jorisvandenbossche grahamjeffries + jorisvandenbossche remove read_excel kwd NotImplemented error, update documentation #11544 0e10a9d

@jreback jreback added a commit to jreback/pandas that referenced this issue Mar 27, 2017

@jorisvandenbossche @jreback jorisvandenbossche + jreback Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR pandas-dev#12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 10d8c40

jreback referenced this issue Mar 27, 2017

Closed

Remove NotImplementedError for parse_dates keyword in read_excel #15820

@jreback jreback added a commit that referenced this issue Mar 27, 2017

@grahamjeffries @jreback grahamjeffries + jreback Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR #12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 b36a461

@jreback jreback added a commit that referenced this issue Mar 27, 2017

@grahamjeffries @jreback grahamjeffries + jreback Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR #12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 7e43c78

jreback closed this in 1dab800 Mar 28, 2017

@mattip mattip added a commit to mattip/pandas that referenced this issue Apr 3, 2017

@grahamjeffries @mattip grahamjeffries + mattip Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR pandas-dev#12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 40b4e24

@mattip mattip added a commit to mattip/pandas that referenced this issue Apr 3, 2017

@jreback @mattip jreback + mattip BUG: index_names can be None when processing date conversions 
closes #15820
closes #11544
 f0c3954

@linebp linebp added a commit to linebp/pandas that referenced this issue Apr 17, 2017

@grahamjeffries @linebp grahamjeffries + linebp Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR pandas-dev#12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 083f451

@linebp linebp added a commit to linebp/pandas that referenced this issue Apr 17, 2017

@jreback @linebp jreback + linebp BUG: index_names can be None when processing date conversions 
closes #15820
closes #11544
 818be81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment