Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: statsmodel 0.9.0 #18452

Closed
tdpetrou opened this issue Nov 23, 2017 · 1 comment
Closed

COMPAT: statsmodel 0.9.0 #18452

tdpetrou opened this issue Nov 23, 2017 · 1 comment
Labels
Admin Administrative tasks related to the pandas project Compat pandas objects compatability with Numpy or Python functions
Milestone
0.24.0

Comments

@tdpetrou
Copy link
Contributor

tdpetrou commented Nov 23, 2017 •
edited by jreback
Loading

xref #18341

In the currently released version of statsmodels module statsmodels/discrete/discrete_model.py does this:

from pandas.core.api import get_dummies

@TomAugspurger fixed this here

In #18264 we tried to remove the get_dummies import from core.api and put it in core.reshape.api. This caused statsmodels to fail. We kept get_dummies in core.api with a TODO to remove it whenever statsmodels makes their next release.

We only have to delete this line as the import was kept in core.reshape.api
@jreback jreback added this to the 0.22.0 milestone Nov 23, 2017
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Nov 23, 2017
@jreback jreback changed the title Remove get_dummies import from core.api when statsmodels releases next version COMPAT: statsmodel 0.9.0 Nov 23, 2017
@jreback jreback added the Admin Administrative tasks related to the pandas project label Nov 23, 2017
@jreback jreback mentioned this issue Jan 16, 2018
Closed
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.23.0, 0.24.0 Mar 29, 2018
@TomAugspurger
Copy link
Contributor

0.9 is out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Admin Administrative tasks related to the pandas project Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
4 participants
@jreback @jorisvandenbossche @TomAugspurger @tdpetrou