Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI remove redundant checks covered by pyupgrade #37133

Closed
MarcoGorelli opened this issue Oct 15, 2020 · 0 comments · Fixed by #37138
Closed

CI remove redundant checks covered by pyupgrade #37133

MarcoGorelli opened this issue Oct 15, 2020 · 0 comments · Fixed by #37138
Labels
Code Style Code style, linting, code_checks
Milestone

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Oct 15, 2020

Some of these checks, e.g.

    MSG='Check for python2-style file encodings' ; echo $MSG
    invgrep -R --include="*.py" --include="*.pyx" -E "# -\*- coding: utf-8 -\*-" pandas scripts
    RET=$(($RET + $?)) ; echo $MSG "DONE"

    MSG='Check for python2-style super usage' ; echo $MSG
    invgrep -R --include="*.py" -E "super\(\w*, (self|cls)\)" pandas
    RET=$(($RET + $?)) ; echo $MSG "DONE"

are already checked by pyupgrade.

Opening this as a placeholder to go through the checks and see what no longer needs to be there

EDIT

also, as a note, in pandas/core/generic.py there is an instance of .. warning:, but the Check for incorrect sphinx directives isn't picking it up. pygrep finds it though. I'm inclined to move all of these over to pre-commit so that they're cross-platform and can selectively be run only on staged files

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Oct 15, 2020
@jreback jreback added this to the 1.2 milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants