Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Ignoring F821 in developer.rst, that are breaking the build #24160

Merged
merged 1 commit into from
Dec 8, 2018
Merged

DOC: Ignoring F821 in developer.rst, that are breaking the build #24160

merged 1 commit into from
Dec 8, 2018

Conversation

datapythonista
Copy link
Member

I merged #18201 without a rebase, and I didn't realize it'd break the CI, because of flake8 errors (variable not defined) in an example that is not supposed to run.

Fixing the CI by ignoring the F821 errors.

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #24160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24160   +/-   ##
=======================================
  Coverage    92.2%    92.2%           
=======================================
  Files         162      162           
  Lines       51700    51700           
=======================================
  Hits        47670    47670           
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.6% <ø> (ø) ⬆️
#single 43.02% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c911151...064a87e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #24160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24160   +/-   ##
=======================================
  Coverage    92.2%    92.2%           
=======================================
  Files         162      162           
  Lines       51700    51700           
=======================================
  Hits        47670    47670           
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.6% <ø> (ø) ⬆️
#single 43.02% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c911151...064a87e. Read the comment docs.

@TomAugspurger
Copy link
Contributor

These comments will show up in the rendered docs, right?

What's the plan for handling this long-term?

@datapythonista
Copy link
Member Author

Yes, I think they are rendered. For the long term we may try to either avoid having any error (in this case define metadata), or to ignore them in flake8-rst. It surely would be nice to not show them to the user.

I can take a look for better ways, but wanted to do a quick fix, as this is currently breaking the CI.

@TomAugspurger TomAugspurger merged commit c0b9eea into pandas-dev:master Dec 8, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants