Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dicts with OrderedDicts in groupby aggregation functions #25693

Merged
merged 7 commits into from Mar 19, 2019

Conversation

Projects
None yet
6 participants
@alexander-ponomaroff
Copy link
Contributor

alexander-ponomaroff commented Mar 12, 2019

  • closes #25692
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #25693 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25693      +/-   ##
==========================================
- Coverage   91.28%   91.28%   -0.01%     
==========================================
  Files         173      173              
  Lines       52965    52965              
==========================================
- Hits        48349    48348       -1     
- Misses       4616     4617       +1
Flag Coverage Δ
#multiple 89.86% <100%> (ø) ⬆️
#single 41.74% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/groupby/generic.py 87% <100%> (ø) ⬆️
pandas/util/testing.py 88.98% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c341dc...b472e66. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #25693 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25693   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         172      172           
  Lines       52965    52965           
=======================================
  Hits        48335    48335           
  Misses       4630     4630
Flag Coverage Δ
#multiple 89.83% <100%> (ø) ⬆️
#single 41.74% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/groupby/generic.py 87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d951d...6690b00. Read the comment docs.

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Mar 14, 2019

Hello @alexander-ponomaroff! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-18 17:17:00 UTC

@alexander-ponomaroff alexander-ponomaroff changed the title [WIP] Replace dicts with OrderedDicts in groupby aggregation functions Replace dicts with OrderedDicts in groupby aggregation functions Mar 15, 2019

@gfyoung gfyoung added the Groupby label Mar 15, 2019

@jreback jreback added this to the 0.25.0 milestone Mar 18, 2019

@jreback

This comment has been minimized.

Copy link
Contributor

jreback commented Mar 18, 2019

looks good. can you address @TomAugspurger comment. ping on green.

@alexander-ponomaroff

This comment has been minimized.

Copy link
Contributor Author

alexander-ponomaroff commented Mar 18, 2019

@jreback Done, tests are green.

@WillAyd WillAyd merged commit db6993c into pandas-dev:master Mar 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@WillAyd

This comment has been minimized.

Copy link
Member

WillAyd commented Mar 19, 2019

@alexander-ponomaroff

This comment has been minimized.

Copy link
Contributor Author

alexander-ponomaroff commented Mar 19, 2019

No problem @WillAyd :)

sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 20, 2019

Merge remote-tracking branch 'origin/master' into fix-25557
* origin/master:
  DOC: clean bug fix section in whatsnew (pandas-dev#25792)
  DOC: Fixed PeriodArray api ref (pandas-dev#25526)
  Move locale code out of tm, into _config (pandas-dev#25757)
  Unpin pycodestyle (pandas-dev#25789)
  Add test for rdivmod on EA array (GH23287) (pandas-dev#24047)
  ENH: Support datetime.timezone objects (pandas-dev#25065)
  Cython language level 3 (pandas-dev#24538)
  API: concat on sparse values (pandas-dev#25719)
  TST: assert_produces_warning works with filterwarnings (pandas-dev#25721)
  make core.config self-contained (pandas-dev#25613)
  CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721)
  TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)
  DOC: Fix typo in docstring of DataFrame.memory_usage  (pandas-dev#25770)
  Replace dicts with OrderedDicts in groupby aggregation functions (pandas-dev#25693)
  TST: Fixturize tests/frame/test_missing.py (pandas-dev#25640)
  DOC: Improve the docsting of Series.iteritems (pandas-dev#24879)
  DOC: Fix function name. (pandas-dev#25751)
  Implementing iso_week_year support for to_datetime (pandas-dev#25541)
  DOC: clarify corr behaviour when using a callable (pandas-dev#25732)
  remove unnecessary check_output (pandas-dev#25755)

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.