Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix reindexing with a tz-aware index and method='nearest' #31511

Merged
merged 8 commits into from
Feb 3, 2020
Merged

BUG: fix reindexing with a tz-aware index and method='nearest' #31511

merged 8 commits into from
Feb 3, 2020

Conversation

kandersolar
Copy link
Contributor

@kandersolar kandersolar commented Jan 31, 2020 •
edited
Loading

First pandas PR, happy to make changes as needed. Is a whatsnew entry needed? And if so, I assume it should go in v1.0.1.rst?

@kandersolar
Copy link
Contributor Author

Thanks @MarcoGorelli for the guidance! Is there anything else I can improve?

@kandersolar
Copy link
Contributor Author

Docs build fail seems unrelated, transient network error? https://github.com/pandas-dev/pandas/pull/31511/checks?check_run_id=419939179#step:6:37

@charlesdong1991
Copy link
Member

@kanderso-nrel likely a network issue, you could add a whatsnew note in 1.1 and try it again

@charlesdong1991 charlesdong1991 added the Indexing Related to indexing on series/frames, not to indexes themselves label Jan 31, 2020
@jreback jreback added the Timezones Timezone data dtype label Feb 2, 2020
jreback
jreback requested changes Feb 2, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some comments, pls merge master. ping on green.

doc/source/whatsnew/v1.1.0.rst Outdated Show resolved Hide resolved
pandas/core/indexes/base.py Outdated Show resolved Hide resolved
@kandersolar
Copy link
Contributor Author

@jreback all green after #31594

@jreback jreback added this to the 1.1 milestone Feb 3, 2020
@jreback jreback merged commit 64336ff into pandas-dev:master Feb 3, 2020
@jreback
Copy link
Contributor

jreback commented Feb 3, 2020

thanks!

@kandersolar kandersolar mentioned this pull request Feb 5, 2020
Merged
@spencerkclark spencerkclark mentioned this pull request Feb 6, 2020
Closed
@TomAugspurger TomAugspurger mentioned this pull request Feb 14, 2020
Closed
@simonjayhawkins simonjayhawkins mentioned this pull request Feb 21, 2020
Closed
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request Feb 21, 2020
@simonjayhawkins
Backport PR pandas-dev#31511 on branch 1.0.x (BUG: fix reindexing wit…
01d6c35 
…h a tz-aware index and method='nearest')
jorisvandenbossche pushed a commit that referenced this pull request Feb 21, 2020
@simonjayhawkins
Backport PR #31511 on branch 1.0.x (BUG: fix reindexing with a tz-awa…
b53a718 
…re index and method='nearest') (#32150)
@spencerkclark spencerkclark mentioned this pull request Feb 22, 2020
Merged
4 tasks
@spencerkclark spencerkclark mentioned this pull request Mar 22, 2020
Merged
4 tasks
@simonjayhawkins simonjayhawkins mentioned this pull request May 6, 2020
Merged
@kandersolar kandersolar deleted the reindex_tzaware branch March 10, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Timezones Timezone data dtype
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Warning while reindexing tz aware index with method='nearest'
4 participants
@kandersolar @charlesdong1991 @jreback @MarcoGorelli