TST: troubleshoot npdev build #31594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gentle ping @jreback this fixes the CI |
jreback
added
CI
|
you have an included profile file :( remove ping when pushed can just merge |
|
thanks! |
5 tasks
| # "Cannot interpret 'foo' as a data type" | ||
| msg = "|".join( | ||
| ["data type not understood", "Cannot interpret '.*' as a data type"] | ||
| ) |
There was a problem hiding this comment.
I think we simply shouldn't test the message here, we are literally testing numpy here
|
Remember that in general, CI fixes should be backported |
|
@meeseeksdev backport to 1.0.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Feb 3, 2020
TomAugspurger
pushed a commit
that referenced
this pull request
Feb 3, 2020
* TST: troubleshoot npdev build (#31594) * fixup Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.