Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null pointer exemption (encoder.go) #8

Closed
Ahudeda opened this issue Nov 19, 2023 · 2 comments
Closed

Null pointer exemption (encoder.go) #8

Ahudeda opened this issue Nov 19, 2023 · 2 comments
Assignees
@pandatix
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Ahudeda
Copy link

Ahudeda commented Nov 19, 2023

https://github.com/pandatix/nvdapi/blob/11bc999ed1b9c8c65857c8e2a7e48f2aeed3c0b6/v2/cve.go#L30C1-L33C61

VersionStart       *string `nvd:"versionStart,omitempty"`
VersionStartType   *string `nvd:"versionStartType,omitempty"`
VersionEnd         *string `nvd:"versionEnd,omitempty"`
VersionEndType     *string `nvd:"versionEndType,omitempty"`

every line missing trailing comma
null pointer on encoder.go (if pts[2] == "noValue" && f.Kind() == reflect.Bool && f.Bool() {)
@pandatix pandatix added bug Something isn't working good first issue Good for newcomers labels Nov 19, 2023
@pandatix pandatix self-assigned this Nov 19, 2023
@pandatix
Copy link
Owner

Hi @Ahudeda,

Thanks for finding this mistake. I will fix it soon (under <48h) when available, or accept a PR if one pops up.

Bests, Lucas.

@pandatix
Copy link
Owner

Hey, should be fixed by v0.6.5 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pandatix pandatix

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pandatix @Ahudeda