continuous crashing

[OgelGames]

For the last few hours the server has been in a crash loop caused by pipeworks:

2020-04-09 01:53:41: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'pipeworks' in callback environment_Step(): /usr/local/share/minetest/builtin/common/vector.lua:122: attempt to index local 'a' (a nil value)
2020-04-09 01:53:41: ERROR[Main]: stack traceback:
2020-04-09 01:53:41: ERROR[Main]: 	/usr/local/share/minetest/builtin/common/vector.lua:122: in function 'multiply'
2020-04-09 01:53:41: ERROR[Main]: 	/data/world//worldmods/pipeworks/luaentity.lua:346: in function 'move_entities_globalstep_part2'
2020-04-09 01:53:41: ERROR[Main]: 	/data/world//worldmods/pipeworks/luaentity.lua:377: in function 'func'
2020-04-09 01:53:41: ERROR[Main]: 	...ocal/share/minetest/builtin/profiler/instrumentation.lua:106: in function 'f'
2020-04-09 01:53:41: ERROR[Main]: 	.../worldmods/monitoring/monitoring/metrictypes/counter.lua:46: in function 'globalstep'
2020-04-09 01:53:41: ERROR[Main]: 	...//worldmods/monitoring/monitoring/builtin/globalstep.lua:29: in function <...//worldmods/monitoring/monitoring/builtin/globalstep.lua:20>
2020-04-09 01:53:41: ERROR[Main]: 	/usr/local/share/minetest/builtin/game/register.lua:429: in function </usr/local/share/minetest/builtin/game/register.lua:413>
2020-04-09 01:53:41: ERROR[Main]: stack traceback:

I have managed to fix it temporally by adding some nil checks, and switching to my fork on GitLab.

[BuckarooBanzay]

Looks like this is called here with entity._acceleration being nil:
https://gitlab.com/VanessaE/pipeworks/-/blob/master/luaentity.lua#L346

And accessed here as a:
https://github.com/minetest/minetest/blob/stable-5/builtin/common/vector.lua#L122

No clue yet why this should change after an engine update though... 😛

[OgelGames]

Just had a few more crashes caused by the same thing, looks like something is wrong the _acceleration value...

2020-04-09 14:40:12: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'pipeworks' in callback environment_Step(): Invalid position (expected table got nil).
2020-04-09 14:40:12: ERROR[Main]: stack traceback:
2020-04-09 14:40:12: ERROR[Main]: 	[C]: in function 'set_acceleration'
2020-04-09 14:40:12: ERROR[Main]: 	/data/world//worldmods/pipeworks/luaentity.lua:124: in function '_set_master'
2020-04-09 14:40:12: ERROR[Main]: 	/data/world//worldmods/pipeworks/luaentity.lua:163: in function '_add_attached'
2020-04-09 14:40:12: ERROR[Main]: 	/data/world//worldmods/pipeworks/luaentity.lua:191: in function '_add_loaded'
2020-04-09 14:40:12: ERROR[Main]: 	/data/world//worldmods/pipeworks/luaentity.lua:362: in function 'move_entities_globalstep_part2'
2020-04-09 14:40:12: ERROR[Main]: 	/data/world//worldmods/pipeworks/luaentity.lua:377: in function 'func'
2020-04-09 14:40:12: ERROR[Main]: 	...ocal/share/minetest/builtin/profiler/instrumentation.lua:106: in function 'f'
2020-04-09 14:40:12: ERROR[Main]: 	.../worldmods/monitoring/monitoring/metrictypes/counter.lua:46: in function 'globalstep'
2020-04-09 14:40:12: ERROR[Main]: 	...//worldmods/monitoring/monitoring/builtin/globalstep.lua:29: in function <...//worldmods/monitoring/monitoring/builtin/globalstep.lua:20>
2020-04-09 14:40:12: ERROR[Main]: 	/usr/local/share/minetest/builtin/game/register.lua:429: in function </usr/local/share/minetest/builtin/game/register.lua:413>
2020-04-09 14:40:12: ERROR[Main]: stack traceback:

I've added another quick fix for the moment 😉

[BuckarooBanzay]

i restored the server at test.pandorabox.io to the state of 2020-04-10 02-00, updated to minetest 5.2.0 and teleported to shanis's place.

The place is full of pipeworks with various items dropping out of them, but no crashes so far... 🤷

EDIT: nevermind, i reverted your fixes in the mods-repo and the same happens.... 🎉