Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix of audio and sub tracks with multiple version of same movie #56

Closed
guillaume-cerf opened this issue Oct 21, 2023 · 13 comments
Closed

Comments

@guillaume-cerf
Copy link

guillaume-cerf commented Oct 21, 2023

Hello Pannal,

Thanks for your work !

I found out that when you have multiple version of the same movie in the same plex library, in the settings of the playback, you see all tracks from those different version.

For example i have two version of one movie in one library, 1st version 4 audio tracks + 2 pgs + 1 srt extern, 2nd version 7 audio tracks + 4 pgs + same 1 srt extern. So in total i see at the same time 11 audio tracks and 8 sub, on both setting's interface before and during the playback of the movie.

Best regards

@guillaume-cerf guillaume-cerf changed the title Mixe of audio and sub tracks with multiple version of same movie Mix of audio and sub tracks with multiple version of same movie Oct 21, 2023
@pannal
Copy link
Owner

pannal commented Oct 21, 2023

Yep, this is a known issue, which coincidentally I'm currently looking at; See here.

I'm currently in the progress of properly debugging this, the work in progress branch is this.

You can try this version (just overwrite your original script.plexmod with the archive contents), where I've at least fixed the initial preplay display and stream selection.

It's far from ready, though, but it should work a little better than the current release. I've still got a lot to investigate, such as media selection, multi-media resume, and multi-part resume.

I'm hoping for a release soon, though.

@guillaume-cerf
Copy link
Author

didn't know, funny tho ;)
l'll try tomorrow but it can wait, i'm happy that someone is keeping the add on working. Maybe you should work for plex ;) even tho they've been firing some employees to reduce opex.

@pannal
Copy link
Owner

pannal commented Oct 22, 2023

Current version should work semi-well on Movies (new media choice button instead of "play version"); returning to preplay is still "broken" (returns to the wrong media choice).

@pannal
Copy link
Owner

pannal commented Oct 22, 2023

OK, latest version works on Movies and Episodes, please check.

@guillaume-cerf
Copy link
Author

I will try to see on my tablet tonight i am away during the week, already on the train.

i'll let you know as soon as possible

@stark2006
Copy link

stark2006 commented Oct 23, 2023

OK, latest version works on Movies and Episodes, please check.

Hi, it works but it seems, the icon is hidden (also there is icon space). The Playversion submenu opens which can be seen in the screenshots.
button

Edit: Please add media button: media-focus.png & media.png in the repository.

@pannal
Copy link
Owner

pannal commented Oct 23, 2023

Haha, forgot to add them. Fixed.

@stark2006
Copy link

Haha, forgot to add them. Fixed.

Thank you

@pannal
Copy link
Owner

pannal commented Oct 25, 2023

Is this stable for you guys?

@guillaume-cerf
Copy link
Author

to be honest i didn't quit understood how to update the files on the shield, do you have a tutorial to do it ?

@pannal
Copy link
Owner

pannal commented Oct 26, 2023

https://kodi.wiki/view/Kodi_data_folder

So you'll find the addons folder inside that folder on any Android device. Inside you'll find script.plexmod, which you can replace with the archive.

@stark2006
Copy link

Is this stable for you guys?

Yes thanks, after a long time play version is improved. It seems stable.

There is one more issue which had lasted from a long time. Which I had mentioned here earlier.
plexinc#359

@pannal
Copy link
Owner

pannal commented Nov 1, 2023

Is this stable for you guys?

Yes thanks, after a long time play version is improved. It seems stable.

There is one more issue which had lasted from a long time. Which I had mentioned here earlier. plexinc#359

Will be fixed in the next version.

@pannal pannal closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants