Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LiquidDoc] Lone single quote in comment breaks plugin #176

Closed
davidwarrington opened this issue Oct 27, 2023 · 1 comment
Closed

[LiquidDoc] Lone single quote in comment breaks plugin #176

davidwarrington opened this issue Oct 27, 2023 · 1 comment
Labels
Bug Something isn't working in the vscode extension

Comments

@davidwarrington
Copy link
Collaborator

{% comment %}
  There's a non-breaking single quote in this line

  Accepts:
  - update_url: {Boolean} There's a breaking single quote here

  Usage:
  {% render 'product-variant-picker', product: product %}
{% endcomment %}

In the above example the first single quote after LiquidDoc begins appears to be detected as opening a string. The syntax highlighting breaks, and after the comment I no longer get autocompletions. A single quote in a word before Accept: seems to be ignored as expected.

I found this in the product-variant-picker snippet in Dawn.

@davidwarrington davidwarrington added the Bug Something isn't working in the vscode extension label Oct 27, 2023
@panoply
Copy link
Owner

panoply commented Oct 28, 2023

Should maybe make some action on in previous chats pertaining to Liquid docs. Will patch in meantime.

@panoply panoply closed this as completed in 0dc3575 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working in the vscode extension
Projects
None yet
Development

No branches or pull requests

2 participants