Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore using custom array hash function to avoid array allocation #190

Closed
JacobEvelyn opened this issue Jul 21, 2021 · 2 comments
Closed

Explore using custom array hash function to avoid array allocation #190

JacobEvelyn opened this issue Jul 21, 2021 · 2 comments

Comments

@JacobEvelyn
Copy link
Member

See: #189 (comment)
@JacobEvelyn JacobEvelyn mentioned this issue Jul 21, 2021
Merged
2 tasks
@JacobEvelyn
Copy link
Member Author

Discussed today with @jemmaissroff—this is contingent on us keeping the use of a hash value as our lookup key. If we decide to go back to array keys, implementing a custom hash function would make no sense.

@JacobEvelyn
Copy link
Member Author

Closing this as we decided we don't trust pure hash keys in the long run. cc @jemmaissroff @ms-ati

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JacobEvelyn