Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default for Environment global_path #90

Closed
jkelling opened this issue Feb 19, 2019 · 1 comment
Closed

Fix default for Environment global_path #90

jkelling opened this issue Feb 19, 2019 · 1 comment

Comments

@jkelling
Copy link

jkelling commented Feb 19, 2019

The default ctor for Environment sets global_path to "./" ( environment.hpp:40 ) . Which breaks absolute paths in calls to render_file(..) or rather parse_template(..).

Breaking absolute paths is quite unexpected behavior for a default, especially because it is not documented.

I suggest to change the default to "" (empty string) this still allows relative paths and does not break absolute paths.

@pantor pantor changed the title Fix default for Environmen global_path Fix default for Environment global_path Feb 19, 2019
@pantor
Copy link
Owner

pantor commented Apr 7, 2019

I think you're right. With the latest commit, I now changed the default path to the empty string, so it does not break absolute paths anymore. Thanks!

@pantor pantor closed this as completed Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants