Skip to content

Commit

Permalink
Fix formatting and restore (object) where needed in comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Eric-Arellano committed Jun 22, 2019
1 parent 536ebf7 commit 0042167
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ def __init__(self, dependencies_archive_url=None, sources=None,
payload.add_fields({
'dependencies_archive_url': PrimitiveField(dependencies_archive_url),
})
super().__init__(sources=sources, address=address,
payload=payload, **kwargs)
super().__init__(sources=sources, address=address, payload=payload, **kwargs)

@property
def dependencies_archive_url(self):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def test_no_sources(self, unused_test_name, resolve_local):
@parameterized.expand(CHECKER_RESOLVE_METHOD)
def test_pass(self, unused_test_name, resolve_local):
self.create_file('a/python/pass.py', contents=dedent("""
class UpperCase:
class UpperCase(object):
pass
"""))
target = self.make_target('a/python:pass', PythonLibrary, sources=['pass.py'])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def compile_time_check_decorator(cls):
@compile_time_check_decorator
class BarB:
class BarB(object):
pass
""")})

Expand All @@ -57,7 +57,7 @@ class BarB:
@compile_time_check_decorator
class BazD:
class BazD(object):
pass
""")}, dependencies=['//src/python/a'])

Expand Down
6 changes: 1 addition & 5 deletions src/python/pants/backend/jvm/targets/jvm_binary.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,11 +360,7 @@ def __init__(self,
'extra_jvm_options': PrimitiveField(list(extra_jvm_options or ())),
})

super().__init__(name=name,
address=address,
payload=payload,
sources=sources,
**kwargs)
super().__init__(name=name, address=address, payload=payload, sources=sources, **kwargs)

@property
def basename(self):
Expand Down
3 changes: 1 addition & 2 deletions src/python/pants/binaries/binary_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ def file_name(self):
class NoDownloadUrlsError(ValueError): pass

def __new__(cls, download_path, urls):
this_object = super().__new__(
cls, download_path, tuple(urls))
this_object = super().__new__(cls, download_path, tuple(urls))

if not this_object.urls:
raise cls.NoDownloadUrlsError(
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/core_tasks/clean.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,5 @@ def execute(self):
logger.debug("Forked an asynchronous clean-all worker at pid: {}".format(pid))
else:
# Recursively removes pants cache; user waits patiently.

logger.info('For async removal, run `./pants clean-all --async`')
safe_rmtree(pants_trash)

0 comments on commit 0042167

Please sign in to comment.