Skip to content

Commit

Permalink
Fix Python 3 option integration test issue with unicode (#6755)
Browse files Browse the repository at this point in the history
  • Loading branch information
OniOni authored and Eric-Arellano committed Nov 10, 2018
1 parent ca509a7 commit 2ee9b42
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion build-support/known_py3_integration_failures.txt
Expand Up @@ -3,6 +3,5 @@ tests/python/pants_test/backend/jvm/tasks:checkstyle_integration
tests/python/pants_test/backend/python/tasks:integration
tests/python/pants_test/backend/python/tasks:python_native_code_testing
tests/python/pants_test/engine/legacy:pants_engine_integration
tests/python/pants_test/option:options_integration
tests/python/pants_test/pantsd:pantsd_integration
tests/python/pants_test/projects:testprojects_integration
Expand Up @@ -37,7 +37,7 @@ def test_pants_no_quiet_output_file(self):
pants_run = self.run_pants(['--no-quiet', 'export', '--output-file={}'.format(f.name)])
self.assert_success(pants_run)

json_string = f.read()
json_string = f.read().decode('utf8')
# Make sure the json is valid from the file read.
json.loads(json_string)
# Make sure json string does not appear in stdout.
Expand Down

0 comments on commit 2ee9b42

Please sign in to comment.