Skip to content

Commit

Permalink
Revert pytest successful test caching in CI. (#5016)
Browse files Browse the repository at this point in the history
This reverts commit c2a19ab: see comment on #4819
  • Loading branch information
Stu Hood committed Oct 26, 2017
1 parent ef4197c commit 39bbec6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
13 changes: 3 additions & 10 deletions pants.travis-ci.ini
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,14 @@
# Turn off all nailgun use.
use_nailgun: False

local_artifact_cache: %(pants_bootstrapdir)s/artifact_cache

[compile.zinc]
# If we use the default of 1 worker per core, we see too many cores under travis
# and get oomkilled from launching too many workers with too much total memory
# overhead.
worker_count: 4

[cache.test.pytest]
# test.pytest supports successful test result caching, we use this to reduce CI times/costs.
read_from: ["%(local_artifact_cache)s"]
write_to: ["%(local_artifact_cache)s"]

[test.pytest]
# This ensures test caching is maximally effective; ie: per-target.
fast: false
options: ['--duration=3']

options: ['--duration=3']
# Increase isolation. This is the direction that all tests will head in soon via #4586.
fast: false
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
unicode_literals, with_statement)

import os
from unittest import skipIf
from unittest import skip, skipIf

from pants.build_graph.address import Address
from pants.build_graph.target import Target
Expand Down Expand Up @@ -199,6 +199,7 @@ def test_no_record_classpath(self):
extra_args=['--no-compile-zinc-capture-classpath']) as found:
self.assertFalse(classpath_filename in found)

@skip("TODO: Fix post #5016.")
@skipIf(is_missing_jvm('1.8'), 'no java 1.8 installation on testing machine')
def test_custom_javac(self):
with self.temporary_workdir() as workdir:
Expand Down

0 comments on commit 39bbec6

Please sign in to comment.