Skip to content
Permalink
Browse files

Fix regression to python interpreter selection test from #7257 (#7333)

### Problem
#7257 resulted in `test_pytest_run.py::test_target_constraints_with_no_sources` failing because `ci.sh` now sets interpreter constraints for Py2 runs whereas it earlier did not set any. So, the test is pulling in the global interpreter constraints and [failing to find an acceptable interpreter](https://travis-ci.org/pantsbuild/pants/jobs/502998214#L1310).

### Solution
Set the test to be hermetic, so that external dependencies aren't pulled in.

### Result
`PY=python2.7 PANTS_PYTHON_SETUP_INTERPRETER_CONSTRAINTS="['CPython==2.7.15']" ./pants clean-all test tests/python/pants_test/backend/python/tasks:integration -- -k test_target_constraints_with_no_sources` now passes.

Hence, the cron job should now be fixed.
  • Loading branch information...
Eric-Arellano committed Mar 7, 2019
1 parent afb8813 commit 59d92ea1337a61e713f45c8e1674e005dcc479a2
Showing with 4 additions and 0 deletions.
  1. +4 −0 tests/python/pants_test/backend/python/tasks/test_python_run_integration.py
@@ -22,6 +22,10 @@
class PythonRunIntegrationTest(PantsRunIntegrationTest):
testproject = 'testprojects/src/python/interpreter_selection'

@classmethod
def hermetic(cls):
return True

@skip_unless_python3
@ensure_daemon
def test_run_3(self):

0 comments on commit 59d92ea

Please sign in to comment.
You can’t perform that action at this time.