-
-
Notifications
You must be signed in to change notification settings - Fork 626
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix encoding of workunits under pantsd (#6505)
### Problem On python2 under `pantsd`, workunits containing unicode are currently not encoded to bytes because the synthetic stdout that is created in that environment does not have "std" in its name. ### Solution Ensure that all output files in use with `PlainTextReporter` accept writes of raw bytes, and then universally encode non-`binary_type` values. Mark an integration test `@ensure_daemon` to cover this.
- Loading branch information
Stu Hood
committed
Sep 17, 2018
1 parent
606fc83
commit 5a9b6b9
Showing
3 changed files
with
13 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters