Skip to content

Commit

Permalink
Move target.py rules to engine/internals/graph.py (#10372)
Browse files Browse the repository at this point in the history
Everything in the top-level `engine.py` is meant to be publically consumable by plugin authors. Meanwhile, `engine/internals` holds the implementation details and we never expect plugin authors to need to import from it.

Right now, the rules related to targets are in `target.py`, which is a leak - users don't need to access these rules directly.

Less philosophically, this allows us to circumvent an upcoming cycle between `engine/targets.py` and `engine/internals/graph.py`: the dependencies rule will need to use `Owners`, which is defined in `graph.py`, which imports `target.py`.

[ci skip-rust-tests]
  • Loading branch information
Eric-Arellano committed Jul 15, 2020
1 parent 1aaac7a commit 742044b
Show file tree
Hide file tree
Showing 5 changed files with 1,028 additions and 956 deletions.

0 comments on commit 742044b

Please sign in to comment.