Move target.py rules to engine/internals/graph.py
#10372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust-tests]
Eric-Arellano
commented
Jul 15, 2020
Comment on lines
+1366
to
+1374
| try: | ||
| ensure_str_list(value_or_default) | ||
| except ValueError: | ||
| raise InvalidFieldTypeException( | ||
| address, | ||
| cls.alias, | ||
| value_or_default, | ||
| expected_type="an iterable of strings (e.g. a list of strings)", | ||
| ) |
There was a problem hiding this comment.
This is a bug fix. We weren't doing any validation before.
stuhood
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything in the top-level
engine.pyis meant to be publically consumable by plugin authors. Meanwhile,engine/internalsholds the implementation details and we never expect plugin authors to need to import from it.Right now, the rules related to targets are in
target.py, which is a leak - users don't need to access these rules directly.Less philosophically, this allows us to circumvent an upcoming cycle between
engine/targets.pyandengine/internals/graph.py: the dependencies rule will need to useOwners, which is defined ingraph.py, which importstarget.py.[ci skip-rust-tests]