Skip to content

Commit

Permalink
Only skip building wheels on PR builds (#10482)
Browse files Browse the repository at this point in the history
Building on all branch builds has the following benefits:
1) We'll detect the release process breaking before the day of a release.
2) Downstream users can consume any arbitrary Pants commit.

[ci skip-rust]
  • Loading branch information
Eric-Arellano committed Jul 28, 2020
1 parent 93066ac commit ae4c1bd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,8 @@ jobs:
- PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem
- PREPARE_DEPLOY=1
- CACHE_NAME=wheels.linux
if: commit_message !~ /\[ci skip-build-wheels\]/
if: commit_message !~ /\[ci skip-build-wheels\]/ OR type NOT IN (pull_request,
cron)
language: python
name: Build Linux wheels and fs_util
os: linux
Expand Down Expand Up @@ -668,7 +669,8 @@ jobs:
- BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.osx
- PREPARE_DEPLOY=1
- CACHE_NAME=wheels.osx
if: commit_message !~ /\[ci skip-build-wheels\]/
if: commit_message !~ /\[ci skip-build-wheels\]/ OR type NOT IN (pull_request,
cron)
language: generic
name: Build macOS wheels and fs_util
os: osx
Expand Down
4 changes: 3 additions & 1 deletion build-support/bin/generate_travis_yml.py
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,9 @@ def osx_shard(

# See https://docs.travis-ci.com/user/conditions-v1.
SKIP_RUST_CONDITION = r"commit_message !~ /\[ci skip-rust\]/"
SKIP_WHEELS_CONDITION = r"commit_message !~ /\[ci skip-build-wheels\]/"
SKIP_WHEELS_CONDITION = (
r"commit_message !~ /\[ci skip-build-wheels\]/ OR type NOT IN (pull_request, cron)"
)

# ----------------------------------------------------------------------
# Bootstrap engine
Expand Down

0 comments on commit ae4c1bd

Please sign in to comment.