Only skip building wheels on PR builds #10482

Eric-Arellano · 2020-07-28T02:45:16Z

Building on all branch builds has the following benefits:

We'll detect the release process breaking before the day of a release.
Downstream users can consume any arbitrary Pants commit.

[ci skip-rust]
[ci skip-build-wheels]

[ci skip-rust] [ci skip-build-wheels]

coveralls · 2020-07-28T03:03:15Z

Coverage remained the same at 0.0% when pulling 2dbe989 on Eric-Arellano:build-on-branch into f6ffe46 on pantsbuild:master.

The old one didn't actually work correctly. Locally, `TRAVIS_PULL_REQUEST` is never set, meaning that the skip label would never be added.

stuhood

Thank you!

Only skip building wheels on PR builds

3379310

[ci skip-rust] [ci skip-build-wheels]

Eric-Arellano requested review from stuhood, jsirois and benjyw July 28, 2020 02:45

jsirois approved these changes Jul 28, 2020

View reviewed changes

Eric-Arellano added 2 commits July 27, 2020 20:36

Use a better approach

3f84b24

The old one didn't actually work correctly. Locally, `TRAVIS_PULL_REQUEST` is never set, meaning that the skip label would never be added.

Or, not and

2dbe989

stuhood approved these changes Jul 28, 2020

View reviewed changes

Eric-Arellano merged commit ae4c1bd into pantsbuild:master Jul 28, 2020

Eric-Arellano deleted the build-on-branch branch July 28, 2020 04:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only skip building wheels on PR builds #10482

Only skip building wheels on PR builds #10482

Eric-Arellano commented Jul 28, 2020

coveralls commented Jul 28, 2020 •

edited

Loading

stuhood left a comment

Only skip building wheels on PR builds #10482

Only skip building wheels on PR builds #10482

Conversation

Eric-Arellano commented Jul 28, 2020

coveralls commented Jul 28, 2020 • edited Loading

stuhood left a comment

Choose a reason for hiding this comment

coveralls commented Jul 28, 2020 •

edited

Loading