No Pex overhead for changes to source files with run and repl
#10406
Comments
stuhood
pushed a commit
that referenced
this issue
Jul 21, 2020
) Whereas `binary` must include source files in the PEX, `run` does not need to. We get less cache invalidation and generally faster performance by instead having the chroot simply be populated with the source files, similar to how we implement Pytest. We still use a Pex to handle the `entry_point` field and to resolve all 3rd party requirements. Before, with a whitespace change: ``` ▶ /usr/bin/time ./pants run build-support/bin/generate_travis_yml.py > .travis.yml 2.72 real 0.73 user 0.21 sys ``` After, with a whitespace change: ``` ▶ /usr/bin/time ./pants run build-support/bin/generate_travis_yml.py > .travis.yml 1.87 real 0.73 user 0.21 sys ``` Implements half of #10406.
Eric-Arellano
added a commit
that referenced
this issue
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, we build a Pex with the source files. This shouldn't be necessary. We should run the sources as loose files, just like we do with Pytest where we simply populate the chroot with the files.
If done correctly, running
./pants run build-support/bin/check_banned_imports.pywould be nearly instantaneous. Changing its contents would not involve re-building a PEX.We will still use a Pex for third party requirements.
The text was updated successfully, but these errors were encountered: