Speed up repl to no longer rebuild a Pex on source file changes
#10418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust-tests]
[ci skip-rust-tests]
[ci skip-rust-tests]
Eric-Arellano
commented
Jul 21, 2020
Comment on lines
+63
to
+72
| source_files_request = Get( | ||
| UnstrippedPythonSources, UnstrippedPythonSourcesRequest(repl.targets) | ||
| ) | ||
| pex, source_files = await MultiGet(pex_request, source_files_request) | ||
| merged_digest = await Get(Digest, MergeDigests((pex.digest, source_files.snapshot.digest))) | ||
| return ReplRequest( | ||
| digest=merged_digest, | ||
| binary_name=pex.output_filename, | ||
| env={"PEX_EXTRA_SYS_PATH": ":".join(source_files.source_roots)}, | ||
| ) |
There was a problem hiding this comment.
This is duplicated from above. I tried factoring up, but it made things too complex because of needing to add a new request type.
| @@ -32,7 +32,7 @@ async def run_python_binary( | |||
| entry_point = PythonBinarySources.translate_source_file_to_entry_point(binary_sources.files) | |||
| if entry_point is None: | |||
| raise InvalidFieldException( | |||
| "You must either specify `sources` or `entry_point` for the `python_binary` target " | |||
There was a problem hiding this comment.
With the Target API, we can't be certain it's a python_binary target :)
stuhood
approved these changes
Jul 21, 2020
That is the same mental model I'm using. And that it will allow you to use a specific entry point + constrain the interpreter via things like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #10410. Closes #10406.
[ci skip-rust-tests]