Pants Pex releases broke w/ venv mode

[Eric-Arellano]

They originally worked when added for 2.4.0.dev0 in #11591, but broke somewhere in between there and 2.4.0.0rc1 (no PEX releases between then, which was unintentional).

❯ wget https://github.com/pantsbuild/pants/releases/download/release_2.4.0rc1/pants.2.4.0rc1.pex
❯ mv pants.2.4.0rc1.pex dist
❯ cd dist
❯ ./pants.2.4.0rc1.pex --print-stacktrace
15:46:51.05 [INFO] initializing scheduler...
15:46:51.14 [ERROR] no path specified
Traceback (most recent call last):
  File "/data/home/eric/.pex/venvs/short/d02a7ea7/lib/python3.7/site-packages/pants/bin/daemon_pants_runner.py", line 125, in single_daemonized_run
    scheduler, options_initializer = self._core.prepare(options_bootstrapper, complete_env)
  File "/data/home/eric/.pex/venvs/short/d02a7ea7/lib/python3.7/site-packages/pants/pantsd/pants_daemon_core.py", line 129, in prepare
    self._initialize(options_fingerprint, options_bootstrapper, env)
  File "/data/home/eric/.pex/venvs/short/d02a7ea7/lib/python3.7/site-packages/pants/pantsd/pants_daemon_core.py", line 104, in _initialize
    raise e
  File "/data/home/eric/.pex/venvs/short/d02a7ea7/lib/python3.7/site-packages/pants/pantsd/pants_daemon_core.py", line 98, in _initialize
    self._services = self._services_constructor(bootstrap_options_values, self._scheduler)
  File "/data/home/eric/.pex/venvs/short/d02a7ea7/lib/python3.7/site-packages/pants/pantsd/pants_daemon.py", line 91, in _setup_services
    bootstrap_options,
  File "/data/home/eric/.pex/venvs/short/d02a7ea7/lib/python3.7/site-packages/pants/option/global_options.py", line 1386, in compute_pantsd_invalidation_globs
    glob_relpath = os.path.relpath(glob, buildroot)
  File "/data/home/eric/.pyenv/versions/3.7.9/lib/python3.7/posixpath.py", line 457, in relpath
    raise ValueError("no path specified")
ValueError: no path specified

I time boxed myself investigating this, so am not sure why this is happening yet. However, using --unzip mode fixes the issue.

--

Beyond the underlying Pex issue this might reveal, it shows the need for our release process to add a smoke test to building PEXes, something as simple as running --version.

[jsirois]

The issue is a sys.path entry of "" - i.e.: cwd.

pants/src/python/pants/option/global_options.py

Lines 1364 to 1374 in d401cc5

	# Globs calculated from the sys.path and other file-like configuration need to be sanitized
	# to relative globs (where possible).
	potentially_absolute_globs = (
	*sys.path,
	*bootstrap_options.pythonpath,
	*bootstrap_options.pants_config_files,
	)
	for glob in potentially_absolute_globs:
	# NB: We use `relpath` here because these paths are untrusted, and might need to be
	# normalized in addition to being relativized.
	glob_relpath = os.path.relpath(glob, buildroot)

Changing the relpath line to glob_relpath = os.path.relpath(glob or os.getcwd(), buildroot) fixes.

[jsirois]

More generally, the relpath should only be attempted for globs that are absolute paths in the first place.