Make pants.pex more useable. #13842
Merged
Make pants.pex more useable. #13842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there were no ICs; so you'd be as likely as not to have pants.pex blow-up on boot. Additionally, the PEX did not take advantage of --venv mode, which is almost surely what you want for a repeatedly run tool. [ci skip-rust] [ci skip-build-wheels]
|
More oof: Further fix coming. |
…3.9. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
approved these changes
Dec 10, 2021
Merged
|
Sorry I didn't review this. It looks like #11954 is still a problem and impacted a user https://pantsbuild.slack.com/archives/C046T6T9U/p1646756130294799?thread_ts=1646682557.453909&cid=C046T6T9U John suggested the fix for this - I can try to implement and also add the smoke test for pants.pex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
#!/usr/bin/env python3.7so the universalPEX would not work on machines with only Python 3.8 or Python 3.9.
--venvmode, which is almostsurely what you want for a repeatedly run tool.
[ci skip-rust]
[ci skip-build-wheels]