Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala import extraction for inference #13365

Closed
stuhood opened this issue Oct 26, 2021 · 0 comments · Fixed by #13583
Closed

Scala import extraction for inference #13365

stuhood opened this issue Oct 26, 2021 · 0 comments · Fixed by #13583
Assignees
@stuhood @tdyas
Labels
estimate: <1W

Comments

@stuhood
Copy link
Sponsor Member

stuhood commented Oct 26, 2021 •
edited
Loading

Inference for Scala will require (at a minimum) import extraction from Scala sources. In v1 this was accomplished with https://scalameta.org/, which still seems to be active.

https://scalameta.org/docs/trees/guide.html#parse-trees
@stuhood stuhood changed the title Scala dependency inference Scala import extraction for inference Oct 26, 2021
@tdyas tdyas mentioned this issue Nov 5, 2021
Open
@stuhood stuhood self-assigned this Nov 10, 2021
This was referenced Nov 10, 2021
Merged
Merged
stuhood added a commit that referenced this issue Nov 11, 2021
@stuhood
[jvm] Finish enabling thirdparty dependency inference for Scala (#13583)
2457d5b 
Adds the final piece of the puzzle to enable thirdparty dependency inference for Scala... which after everyone's great prepwork just involved adding usage of the `ThirdPartyPackageToArtifactMapping` to the Scala inference rules.

Fixes #13365.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuhood stuhood

@tdyas tdyas

Labels
estimate: <1W
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[jvm] Finish enabling thirdparty dependency inference for Scala stuhood/pants
2 participants
@stuhood @tdyas