-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoCompatibleResolveException
should suggest remedies
#14864
Comments
+1 on that, as it'll allow for expanding and clarifying the topic based on experiences/feedback without adding the delay of a new release & upgrade cycle. |
Related: this error message does not mention what the root target is.
|
Round 1: more clear messageNOTE: The final paragraph does not mention how you should try to find if a target already exists and then how to use that. Realistically, I don't know how to suggest users do that - asking them to use -- Bad dependencies, single root target (eg test):
Bad dependencies, multiple roots (eg repl, Flake8):
Bad input roots, which is only
Round 2: "did you mean?"Will use dependency inference's module mapping to see if there already is a target that uses the same resolve. --
Bad dependencies, multiple roots (eg repl, Flake8):
Bad input roots is the same, given that it only impacts |
Thanks: the round one error messages look good, but I don't think that you need different text for the "single root" vs "multiple roots" case. With regard to "Round Two", I don't think that we should expend much effort on offering suggestions for explicit deps, since explicit deps are rare... and in general, are for things which don't need resolves anyway (resources, primarily). Additionally, in cases where you do actually have multiple choices of resolve, it will usually be in the name anyway, likely via parametrization. So: yes, Round One makes sense. But in terms of improving suggestions, rather than Round Two, would suggest either investing time in enabling |
…ves (pantsbuild#15416) Closes pantsbuild#14864. This code is written generically so that we can hook it up to JVM easily. [ci skip-rust]
…ves (pantsbuild#15416) Closes pantsbuild#14864. This code is written generically so that we can hook it up to JVM easily. [ci skip-rust]
The remedy for a
NoCompatibleResolveException
(both for Python and for the JVM) will generally be to either:2.10.x
: manually, with a unique name.2.11.x
: viaparametrize
.We should include some more information about how to resolve the issue in the error message, possibly by linking to a page on the subject.
The text was updated successfully, but these errors were encountered: