Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPython crash on tab completion in pants repl #15933

Closed
satwell opened this issue Jun 24, 2022 · 1 comment · Fixed by #15934
Closed

IPython crash on tab completion in pants repl #15933

satwell opened this issue Jun 24, 2022 · 1 comment · Fixed by #15934
Labels
bug

Comments

@satwell
Copy link

satwell commented Jun 24, 2022 •
edited

Describe the bug
When [repl].shell is set to ipython, pants uses ipython==7.16.1 by default for pants repl. This version is incompatible with jedi>=0.18, and IPython can crash when using tab completion. (See ipython/ipython#12748 for details.) A fix was released in IPython 7.20.0 (release notes), so this version or newer should be fine.

Could you please update the default IPython version?

Pants version
2.11.1rc2

OS
Linux
@satwell satwell added the bug label Jun 24, 2022
@Eric-Arellano Eric-Arellano mentioned this issue Jun 24, 2022
Merged
@Eric-Arellano
Copy link
Contributor

Thanks for opening this! See #15934 :)

Eric-Arellano added a commit that referenced this issue Jun 24, 2022
@Eric-Arellano
Upgrade default iPython to 7.34, which drops Python 3.6 (#15934)
b8d4613 
Closes #15933.

[ci skip-rust]
[ci skip-build-wheels]
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this issue Jun 24, 2022
@Eric-Arellano
Upgrade default iPython to 7.34, which drops Python 3.6 (pantsbuild#1…
f284d85 
…5934)

Closes pantsbuild#15933.

[ci skip-rust]
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano mentioned this issue Jun 24, 2022
Merged
Eric-Arellano added a commit that referenced this issue Jun 24, 2022
@Eric-Arellano
Upgrade default iPython to 7.34, which drops Python 3.6 (Cherry-pick of
1913bae 
#15934) (#15938)

Upgrade default iPython to 7.34, which drops Python 3.6 (#15934)

Closes #15933.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade default iPython to 7.34, which drops Python 3.6 Eric-Arellano/pants
2 participants
@Eric-Arellano @satwell