Upgrade default iPython to 7.34, which drops Python 3.6 #15934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
@stuhood are you fine with me cherry-picking to 2.13? |
stuhood
approved these changes
Jun 24, 2022
| @@ -25,7 +25,7 @@ class IPython(PythonToolBase): | |||
| options_scope = "ipython" | |||
| help = "The IPython enhanced REPL (https://ipython.org/)." | |||
|
|
|||
| default_version = "ipython==7.16.1" # The last version to support Python 3.6. | |||
| default_version = "ipython>=7.34,<8" # ipython 8 does not support Python 3.7. | |||
There was a problem hiding this comment.
Is dropping Python 3.6 something that we'll want to cherrypick, or should the docs edit and the version bump happen separately?
There was a problem hiding this comment.
We dropped Python 3.6 support in 2.11 with #14803, so this is safe to cherry-pick.
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Jun 24, 2022
…5934) Closes pantsbuild#15933. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15933.
[ci skip-rust]
[ci skip-build-wheels]