Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pants_requirement should include the ; python_version<'3' environment marker #6358

Closed
jsirois opened this issue Aug 17, 2018 · 0 comments
Closed

pants_requirement should include the ; python_version<'3' environment marker #6358

jsirois opened this issue Aug 17, 2018 · 0 comments
Assignees
@jsirois
Labels
bug enhancement

Comments

@jsirois
Copy link
Member

jsirois commented Aug 17, 2018

Until pants can run on python 3, the pants_requirement should add an environment marker to restict the python environment it applies to. After pants only supports >=3.5 a change should be made to the environment marker.
@jsirois jsirois mentioned this issue Aug 17, 2018
Closed
jsirois added a commit to jsirois/pants that referenced this issue Aug 17, 2018
@jsirois
Add an environment marker to pants_requirement.
56e702f 
This properly restricts the dependency to environments pants can
actually run in.

Fixes pantsbuild#6358
@jsirois jsirois mentioned this issue Aug 17, 2018
Merged
@jsirois jsirois self-assigned this Aug 17, 2018
@jsirois jsirois mentioned this issue Aug 17, 2018
Closed
12 tasks
jsirois added a commit to jsirois/pants that referenced this issue Aug 17, 2018
@jsirois
Add an environment marker to pants_requirement.
e21b71b 
This properly restricts the dependency to environments pants can
actually run in.

Fixes pantsbuild#6358
jsirois added a commit that referenced this issue Aug 17, 2018
@jsirois
Add an environment marker to pants_requirement. (#6361)
b3b540c 
This properly restricts the dependency to environments pants can
actually run in.

Fixes #6358
CMLivingston pushed a commit to CMLivingston/pants that referenced this issue Aug 27, 2018
@jsirois
Add an environment marker to pants_requirement. (pantsbuild#6361)
46e86bd 
This properly restricts the dependency to environments pants can
actually run in.

Fixes pantsbuild#6358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsirois