New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an environment marker to `pants_requirement`. #6361

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Aug 17, 2018

This properly restricts the dependency to environments pants can
actually run in.

Fixes #6358

@jsirois jsirois requested a review from benjyw Aug 17, 2018

@benjyw
Copy link
Contributor

benjyw left a comment

LGTM as far as it goes, but the CI failures appear to be relevant.

Add an environment marker to `pants_requirement`.
This properly restricts the dependency to environments pants can
actually run in.

Fixes #6358

@jsirois jsirois force-pushed the jsirois:issues/6358 branch from bf71019 to e21b71b Aug 17, 2018

@jsirois jsirois merged commit b3b540c into pantsbuild:master Aug 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6358 branch Aug 17, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Add an environment marker to `pants_requirement`. (pantsbuild#6361)
This properly restricts the dependency to environments pants can
actually run in.

Fixes pantsbuild#6358

jsirois added a commit that referenced this pull request Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment