Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow redirects for HEAD in RESTfulArtifactCache #6411

Closed
jsirois opened this issue Aug 29, 2018 · 0 comments
Closed

Follow redirects for HEAD in RESTfulArtifactCache #6411

jsirois opened this issue Aug 29, 2018 · 0 comments
Assignees
@jsirois
Labels
enhancement

Comments

@jsirois
Copy link
Member

jsirois commented Aug 29, 2018

Currently we take the requests library default which is to follow redirects for all but HEAD. If a cache server want's to send a HEAD redirect there is no reason we should not follow only for this particular method.
@jsirois jsirois self-assigned this Aug 29, 2018
jsirois added a commit to jsirois/pants that referenced this issue Aug 29, 2018
@jsirois
Support HEAD redirects in RESTfulArtifactCache.
fa3e82b 
Tests are modifed such that if any of the four API methods do not
follow redirects, we get a test failure.

Fixes pantsbuild#6411
@jsirois jsirois mentioned this issue Aug 29, 2018
Merged
jsirois added a commit that referenced this issue Aug 29, 2018
@jsirois
Support HEAD redirects in RESTfulArtifactCache. (#6412)
11aa11f 
Tests are modifed such that if any of the four API methods do not
follow redirects, we get a test failure.

Fixes #6411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsirois