Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the internal tags type_checked and partially_type_checked #10244

Merged
merged 4 commits into from Jul 3, 2020

Conversation

Eric-Arellano
Copy link
Contributor

These are no longer necessary. We run MyPy against :: and v2 is able to figure out the right targets to run on.

[ci skip-rust-tests]

@gshuflin
Copy link
Contributor

gshuflin commented Jul 2, 2020

Do we need the explicit tags = {} in the target specifications? Seems cleaner to delete them.

@Eric-Arellano
Copy link
Contributor Author

Do we need the explicit tags = {} in the target specifications? Seems cleaner to delete them.

Oh, nope, we don't. I forgot to delete these.

# Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
…-checked

[ci skip-rust-tests]
# Conflicts:
#	src/python/pants/backend/python/BUILD
#	src/python/pants/backend/python/targets/BUILD
#	src/python/pants/engine/legacy/BUILD
#	src/python/pants/testutil/base/BUILD
#	tests/python/pants_test/auth/BUILD
#	tests/python/pants_test/backend/python/BUILD
@Eric-Arellano Eric-Arellano merged commit e9351d8 into pantsbuild:master Jul 3, 2020
@Eric-Arellano Eric-Arellano deleted the remove-type-checked branch July 3, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants