Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the internal tags type_checked and partially_type_checked #10244

Merged
merged 4 commits into from
Jul 3, 2020
Merged

Remove the internal tags type_checked and partially_type_checked #10244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d358670
Remove the internal tags `type_checked` and `partially_type_checked`
Eric-Arellano Jul 2, 2020
6259f35
Remove some leftover tags values
Eric-Arellano Jul 2, 2020
e3f04d1
Fix two BUILD file issues
Eric-Arellano Jul 2, 2020
5143c2a
Merge branch 'master' of github.com:pantsbuild/pants into remove-type…
Eric-Arellano Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions build-support/bin/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ python_binary(
dependencies = [
':common',
],
tags = {'type_checked'},
)

python_binary(
Expand All @@ -29,7 +28,6 @@ python_binary(
dependencies = [
':common',
],
tags = {'type_checked'},
)

python_binary(
Expand All @@ -38,7 +36,6 @@ python_binary(
dependencies = [
':common',
],
tags = {'type_checked'},
)

python_binary(
Expand All @@ -47,13 +44,11 @@ python_binary(
dependencies = [
':common',
],
tags = {'type_checked'},
)

python_library(
name = 'common',
sources = ['common.py'],
tags = {'type_checked'},
)

python_binary(
Expand All @@ -62,7 +57,6 @@ python_binary(
dependencies = [
':common',
],
tags = {'type_checked'},
)

python_binary(
Expand All @@ -71,7 +65,6 @@ python_binary(
dependencies = [
'3rdparty/python:PyYAML',
],
tags = {'type_checked'},
)

python_binary(
Expand All @@ -81,7 +74,6 @@ python_binary(
'3rdparty/python:ansicolors',
'3rdparty/python:requests',
],
tags = {'type_checked'},
)

python_binary(
Expand All @@ -90,7 +82,6 @@ python_binary(
dependencies = [
':common',
],
tags = {'type_checked'},
)

# TODO: rename this to `release.py` once done porting Bash to Python.
Expand All @@ -102,5 +93,4 @@ python_binary(
'3rdparty/python:beautifulsoup4',
'3rdparty/python:requests',
],
tags = {"type_checked"},
)
1 change: 0 additions & 1 deletion pants-plugins/src/python/internal_backend/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ target(
'pants-plugins/src/python/internal_backend/rules_for_testing:plugin',
'pants-plugins/src/python/internal_backend/utilities',
],
tags = {"partially_type_checked"},
)
1 change: 0 additions & 1 deletion pants-plugins/src/python/internal_backend/rules_for_testing/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@ python_library(
'src/python/pants/engine:goal',
'src/python/pants/engine:rules',
],
tags = {"type_checked"},
)
2 changes: 0 additions & 2 deletions pants-plugins/src/python/internal_backend/utilities/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ python_library(
'src/python/pants/util:ordered_set',
'src/python/pants:version',
],
tags = {"partially_type_checked"},
)

python_tests(
Expand All @@ -19,5 +18,4 @@ python_tests(
'3rdparty/python:setuptools',
':utilities',
],
tags = {"type_checked"},
)
3 changes: 0 additions & 3 deletions src/python/pants/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ python_library(
dependencies=[
'src/python/pants/bin',
],
tags = {'partially_type_checked'},
)

python_library(
Expand All @@ -19,7 +18,6 @@ python_library(
':entry_point',
':version',
],
tags = {'partially_type_checked'},
provides=pants_setup_py(
name='pantsbuild.pants',
description='A scalable build tool for large, complex, heterogeneous repos.',
Expand Down Expand Up @@ -51,7 +49,6 @@ python_library(
'3rdparty/python:packaging',
':version-resource',
],
tags = {"type_checked"},
)

resources(
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/auth/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ python_library(
'src/python/pants/util:memo',
'src/python/pants:version',
],
tags = {"partially_type_checked"},
)
1 change: 0 additions & 1 deletion src/python/pants/backend/awslambda/common/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ python_library(
'src/python/pants/engine:target',
'src/python/pants/engine:unions',
],
tags = {'partially_type_checked'},
)
2 changes: 0 additions & 2 deletions src/python/pants/backend/awslambda/python/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ python_library(
'src/python/pants/engine:unions',
'src/python/pants/python',
],
tags = {"type_checked"},
)

python_tests(
Expand All @@ -37,5 +36,4 @@ python_tests(
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
],
tags = {'partially_type_checked'},
)
1 change: 0 additions & 1 deletion src/python/pants/backend/awslambda/python/examples/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ python_requirement_library(
python_library(
name='hello-lib',
sources = ['hello_lib.py'],
tags = {'partially_type_checked'},
)

python_awslambda(
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/backend/codegen/protobuf/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ python_library(
'src/python/pants/engine:platform',
'src/python/pants/engine:target',
],
tags = {"type_checked"},
)
2 changes: 0 additions & 2 deletions src/python/pants/backend/codegen/protobuf/python/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ python_library(
'src/python/pants/engine:rules',
'src/python/pants/engine:unions',
],
tags = {"type_checked"},
)

python_tests(
Expand All @@ -29,5 +28,4 @@ python_tests(
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
],
tags = {"type_checked"},
)
1 change: 0 additions & 1 deletion src/python/pants/backend/native/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ python_library(
'src/python/pants/backend/native/subsystems',
'src/python/pants/backend/native/subsystems/binaries',
],
tags = {"partially_type_checked"},
)
1 change: 0 additions & 1 deletion src/python/pants/backend/native/config/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ python_library(
'src/python/pants/engine:platform',
'src/python/pants/util:osutil',
],
tags = {"partially_type_checked"},
)
1 change: 0 additions & 1 deletion src/python/pants/backend/native/subsystems/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ python_library(
'src/python/pants/util:memo',
'src/python/pants/util:meta',
],
tags = {"partially_type_checked"},
)
1 change: 0 additions & 1 deletion src/python/pants/backend/native/subsystems/binaries/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ python_library(
'src/python/pants/util:enums',
'src/python/pants/util:memo',
],
tags = {"partially_type_checked"},
)
1 change: 0 additions & 1 deletion src/python/pants/backend/native/subsystems/utils/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@ python_library(
'src/python/pants/util:ordered_set',
'src/python/pants/util:strutil',
],
tags = {"partially_type_checked"},
)
2 changes: 0 additions & 2 deletions src/python/pants/backend/pants_info/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ python_library(
'src/python/pants/source',
'src/python/pants/util:objects',
],
tags = {"type_checked"},
)

python_tests(
Expand All @@ -35,5 +34,4 @@ python_tests(
'src/python/pants/testutil/engine',
'src/python/pants/testutil/subsystem',
],
tags = {"type_checked"},
)
2 changes: 0 additions & 2 deletions src/python/pants/backend/project_info/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ python_library(
'src/python/pants/source',
'src/python/pants/util:objects',
],
tags = {"type_checked"},
)

python_tests(
Expand All @@ -42,5 +41,4 @@ python_tests(
'src/python/pants/testutil/subsystem',
'src/python/pants/util:ordered_set',
],
tags = {"type_checked"},
)
6 changes: 0 additions & 6 deletions src/python/pants/backend/python/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ python_library(
'src/python/pants/goal:task_registrar',
'src/python/pants/python',
],
tags = {"partially_type_checked"},
)

python_library(
Expand All @@ -26,7 +25,6 @@ python_library(
':python_requirements',
'src/python/pants/python',
],
tags = {"partially_type_checked"},
)

python_library(
Expand All @@ -39,7 +37,6 @@ python_library(
'src/python/pants/python',
'src/python/pants/util:meta',
],
tags = {"partially_type_checked"},
)

python_library(
Expand All @@ -48,13 +45,11 @@ python_library(
dependencies = [
'src/python/pants/base:payload_field',
],
tags = {"partially_type_checked"},
)

python_library(
name = 'python_requirements',
sources = ['python_requirements.py'],
tags = {"partially_type_checked"},
)

python_library(
Expand All @@ -70,7 +65,6 @@ python_library(
'src/python/pants/engine:target',
'src/python/pants/python',
],
tags={"type_checked"},
)

python_tests(
Expand Down
2 changes: 0 additions & 2 deletions src/python/pants/backend/python/dependency_inference/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ python_library(
"src/python/pants/util:ordered_set",
"src/python/pants/util:strutil",
],
tags = {"type_checked"},
)

python_tests(
Expand All @@ -28,5 +27,4 @@ python_tests(
":dependency_inference",
"src/python/pants/testutil:test_base",
],
tags = {"type_checked"},
)
1 change: 0 additions & 1 deletion src/python/pants/backend/python/lint/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ python_library(
'src/python/pants/engine:rules',
'src/python/pants/engine:unions',
],
tags = {"type_checked"},
)

python_tests(
Expand Down
3 changes: 1 addition & 2 deletions src/python/pants/backend/python/lint/bandit/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ python_library(
'src/python/pants/python',
'src/python/pants/util:strutil',
],
tags = {"partially_type_checked"},
)

python_tests(
Expand All @@ -38,6 +37,6 @@ python_tests(
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/subsystem',
],
tags = {'integration', 'partially_type_checked'},
tags = ['integration'],
timeout = 180,
)
3 changes: 1 addition & 2 deletions src/python/pants/backend/python/lint/black/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ python_library(
'src/python/pants/python',
'src/python/pants/util:strutil',
],
tags = {"partially_type_checked"},
)

python_tests(
Expand All @@ -38,5 +37,5 @@ python_tests(
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
],
tags = {'integration', 'partially_type_checked'},
tags = ['integration'],
)
3 changes: 1 addition & 2 deletions src/python/pants/backend/python/lint/docformatter/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ python_library(
'src/python/pants/option',
'src/python/pants/python',
],
tags = {"partially_type_checked"},
)

python_tests(
Expand All @@ -37,5 +36,5 @@ python_tests(
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
],
tags = {'integration', 'partially_type_checked'},
tags = ['integration'],
)
3 changes: 1 addition & 2 deletions src/python/pants/backend/python/lint/flake8/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ python_library(
'src/python/pants/option',
'src/python/pants/python',
],
tags = {"partially_type_checked"},
)

python_tests(
Expand All @@ -37,6 +36,6 @@ python_tests(
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
],
tags = {'integration', 'partially_type_checked'},
tags = ['integration'],
timeout = 120,
)
3 changes: 1 addition & 2 deletions src/python/pants/backend/python/lint/isort/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ python_library(
'src/python/pants/python',
'src/python/pants/util:strutil',
],
tags = {"partially_type_checked"},
)

python_tests(
Expand All @@ -38,5 +37,5 @@ python_tests(
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
],
tags = {'integration', 'partially_type_checked'},
tags = ['integration'],
)
3 changes: 1 addition & 2 deletions src/python/pants/backend/python/lint/pylint/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ python_library(
'src/python/pants/option',
'src/python/pants/util:strutil',
],
tags = {"partially_type_checked"},
)

python_tests(
Expand All @@ -37,6 +36,6 @@ python_tests(
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
],
tags = {'integration', 'partially_type_checked'},
tags = ['integration'],
timeout = 180,
)