Use isort v5.x as the default version #10258
Conversation
asherf
force-pushed
the
py3b
branch
2 times, most recently
from
8a09216
to
9175808
Compare
asherf
changed the title
| @@ -9,7 +9,7 @@ class Isort(PythonToolBase): | |||
| """The Python import sorter tool (https://timothycrosley.github.io/isort/).""" | |||
|
|
|||
| options_scope = "isort" | |||
| default_version = "isort>=4.3.21,<4.4" | |||
| default_version = "isort>=5.0.0,<6.0" | |||
There was a problem hiding this comment.
Given the width of the previous range (and the fact that we don't have a lockfile here), should this be isort>=5.0.0,<5.1?
There was a problem hiding this comment.
+1. This reduces the risk of users having something break on them if they don't end up pinning.
There was a problem hiding this comment.
Actually, looks like 5.1.x is the newest. So >=5.1.4,<5.2: https://github.com/timothycrosley/isort/blob/develop/CHANGELOG.md
There was a problem hiding this comment.
It seems that the author is doing the right thing and not introducing breaking changes in 5.x release (when he introduced breaking changes he moved from 4.x to 5.x) hence my choice to allow all 5.x release.
Since there are changes going on there in recent weeks.
| @@ -9,7 +9,7 @@ class Isort(PythonToolBase): | |||
| """The Python import sorter tool (https://timothycrosley.github.io/isort/).""" | |||
|
|
|||
| options_scope = "isort" | |||
| default_version = "isort>=4.3.21,<4.4" | |||
| default_version = "isort>=5.0.0,<6.0" | |||
There was a problem hiding this comment.
+1. This reduces the risk of users having something break on them if they don't end up pinning.
There was a problem hiding this comment.
Is this expected to resolve:
✓ isort succeeded.
/Users/stuhood/.pex/installed_wheels/078dc1a361398512631618298336f252e9b3a4a7/setuptools-49.2.0-py3-none-any.whl/setuptools/distutils_patch.py:26: UserWarning: Distutils was imported before Setuptools. This usage is discouraged and may exhibit undesirable behaviors or errors. Please use Setuptools' objects directly or at least import Setuptools first.
"Distutils was imported before Setuptools. This usage is discouraged "
?
|
(...let's find out!) |
This reverts commit c827416. [ci skip-rust-tests]
This reverts commit c827416. Between isort 4 and isort 5, the requirement on which files are present in the sandbox has changed, and this can result in unstable sort orders. See PyCQA/isort#1147 for the likely cause. Under isort 5, the following set of roots (via `./pants --changed-parent=master list` can result in an order that does not align with `./pants list ::`: https://gist.github.com/stuhood/ec04e86b8a1f44d8b11dcb79a1732a8f In order to use isort 5 stably in a sandbox, we will need to include the necessary transitive dependencies for it to execute its new first-party-detection algorithm, or disable it. [ci skip-rust-tests]
https://github.com/timothycrosley/isort/blob/master/CHANGELOG.md