Revert "Use isort v5.x as the default version (#10258)" #10460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c827416. [ci skip-rust-tests]
Eric-Arellano
approved these changes
Jul 27, 2020
Eric-Arellano
added a commit
that referenced
this pull request
Sep 4, 2020
Closes #10727. We originally reverted this in #10460 due to flakiness in the sorting algorithm, but I can't reproduce this. Toolchain has also been using isort 5.x for the past month without any reported issues. Possibly, isort fixed the issue in between 5.0.0 and 5.5.1 [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c827416.
Between isort 4 and isort 5, the requirement on which files are present in the sandbox has changed, and this can result in unstable sort orders. See PyCQA/isort#1147 for the likely cause. Under isort 5, the following set of roots (via
./pants --changed-parent=master listcan result in an order that does not align with./pants list ::: https://gist.github.com/stuhood/ec04e86b8a1f44d8b11dcb79a1732a8fIn order to use isort 5 stably in a sandbox, we will need to include the necessary transitive dependencies for it to execute its new first-party-detection algorithm, or disable it.
[ci skip-rust-tests]