Port the plugin resolver test to v2 test style. #10424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it used some hackery to get hold of various subsystems to construct a pex to run setup.py, in order to create the plugin dists it then tested against. This change uses v2 test idioms to create and run that pex. As a result, we can delete a lot of code that only hung around because of this one test. Unfortunately, this required making the test functions methods of a test class, meaning we can no longer use pytest.mark.parameterize, and have to "parameterize" manually. [ci skip-rust-tests]
[ci skip-rust-tests]
|
Note the commits are reviewable independently. |
|
Extra bonus: The new tests run in about half the time of the old ones. |
Eric-Arellano
approved these changes
Jul 22, 2020
|
Not going to change the nits because they aren't worth another CI cycle... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it used some hackery to get hold of various
subsystems to construct a pex to run setup.py, in order
to create the plugin dists it then tested against.
This change uses v2 test idioms to create and run that pex.
As a result, we can delete a lot of code that only hung around
because of this one test.
Unfortunately, this required making the test functions methods
of a test class, meaning we can no longer use pytest.mark.parameterize,
and have to "parameterize" manually.
[ci skip-rust-tests]