Demystify get_all_scoped_flag_names mypy kludges. #10459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now centralized in a Protocol that takes the place of the prior Callable of two different signatures (!) and a type ignore. The introduced Protocol is a bit klunky, but self contained and can carry the relevant issue pointer in one spot. [ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
Eric-Arellano
approved these changes
Jul 27, 2020
| # N.B.: We use this callable protool instead of Callable directly to work around the | ||
| # dataclass-specific issue described here: https://github.com/python/mypy/issues/6910 | ||
| class FlagNameProvider(Protocol): | ||
| def __call__(self) -> Iterable: |
There was a problem hiding this comment.
Even better would be to set the return type as Sequence["Options.ScopedFlagNameForFuzzyMatching"]. We used to have this, but I had to remove it when we added file dependencies because we started erroring on a cycle with options.py. Now, we tolerate those cycles, so we can add that import back with:
from typing import TYPE_CHECKING
if TYPE_CHECKING:
import pants.option.options import OptionsThere was a problem hiding this comment.
Even better would not be to have an un-needed cycle and that's easy. I'll follow up instead of snowballing this PR.
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are now centralized in a Protocol that takes the place of the
prior Callable of two different signatures (!) and a type ignore. The
introduced Protocol is a bit klunky, but self contained and can carry
the relevant issue pointer in one spot.
[ci skip-rust-tests]