Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demystify get_all_scoped_flag_names mypy kludges. #10459

Merged
merged 4 commits into from
Jul 27, 2020
Merged

Demystify get_all_scoped_flag_names mypy kludges. #10459

merged 4 commits into from
Jul 27, 2020

Commits on Jul 27, 2020

  1. Demystify get_all_scoped_flag_names mypy kludges. 

    These are now centralized in a Protocol that takes the place of the
prior Callable of two different signatures (!) and a type ignore. The
introduced Protocol is a bit klunky, but self contained and can carry
the relevant issue pointer in one spot.

[ci skip-rust-tests]
    @jsirois
    jsirois committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    cca9d19 View commit details
    Browse the repository at this point in the history

  2. Fix words. 

    # Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
    @jsirois
    jsirois committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    6d5c658 View commit details
    Browse the repository at this point in the history

  3. Support Python3.6 

    # Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
    @jsirois
    jsirois committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    0188485 View commit details
    Browse the repository at this point in the history

  4. Update src/python/pants/option/parser.py 

    Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
    @jsirois @Eric-Arellano
    jsirois and Eric-Arellano committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    67a75f2 View commit details
    Browse the repository at this point in the history