Make GoalSubsystem subclass Subsystem. #10483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Jul 28, 2020
[ci skip-rust] [ci skip-build-wheels]
benjyw
force-pushed
the
goal_subsystem_is_subsystem
branch
from
9c78cd7
to
17aea0c
Compare
It was supposed to have been, I think I didn't push that part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it subclassed the same bases as Subsystem,
and reimplemented some of its functionality, which
was a weird quirk: you'd expect something called GoalSubsystem,
which acts like a Subsystem, to actually be one.
This change folds one of those bases (SubsystemClientMixin)
into Subsystem, and gets rid of it.
A future change will similarly merge Subsystem and Optionable,
since there is now only one kind of Optionable.
[ci skip-rust]
[ci skip-build-wheels]