Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker image for remote execution without GCP/RBE #10515

Merged
merged 1 commit into from Jul 31, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Jul 30, 2020

Problem

The ability of the Pants project to use RBE on GCP ends soon. The image used for remote execution relies on a GCP/RBE image.

Solution

Create a similar image that does not rely on RBE/GCP.

Result

Initial testing of this image internally with Toolchain's remote execution cluster shows that many tests pass. Further iteration may be necessary if some additional dependencies are missing that would have been included in the RBE/GCP image.

@tdyas
Copy link
Contributor Author

tdyas commented Jul 30, 2020

I'd like to publish this to the pantsbuild org on Docker Hub or another registry. I can add a script to do the applicable docker commands. Thoughts?

@tdyas
Copy link
Contributor Author

tdyas commented Jul 30, 2020

  • Also, this image adds Python 3.8 to the image and upgrades all of the Python versions to the latest patch levels.

  • We could test this image using RBE before Toolchain's executor is ready to ensure that it contains all necessary dependencies. That could be done by pushing this image to a repository and then updating the container-image config in pants.remote.toml to that image (in a separate PR).

@coveralls
Copy link

coveralls commented Jul 30, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 5065a65 on tdyas:tc_remote_execution_image into e543e33 on pantsbuild:master.

@tdyas tdyas force-pushed the tc_remote_execution_image branch from 95b085e to 5065a65 Compare July 31, 2020 17:40
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@stuhood stuhood merged commit 685e51d into pantsbuild:master Jul 31, 2020
@tdyas tdyas deleted the tc_remote_execution_image branch February 20, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants