Skip to content

Commit

Permalink
Remove rust source include from integration tests. (#10522)
Browse files Browse the repository at this point in the history
### Problem

Integration tests depend transitively on the `native_engine.so`, which is continuously validated because it must be present to run, and which is bootstrapped before pants starts up. But integration tests were also including the rust sources unnecessarily.

### Solution

Remove the dependency on the rust sources, and the associated target. Also, align the comment about our use of `pants_local_binary` to what we learned in #10279.

[ci skip-rust]
[ci skip-build-wheels]
  • Loading branch information
stuhood committed Jul 31, 2020
1 parent 19de53f commit e543e33
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 15 deletions.
7 changes: 2 additions & 5 deletions src/python/pants/testutil/BUILD
Expand Up @@ -37,12 +37,9 @@ target(
name = 'int-test',
dependencies=[
':int-test-for-export',
# NB: 'pants_run_integration_test.py' runs ./pants in a subprocess, so test results will depend
# on the pants binary and all of its transitive dependencies. Adding the dependencies below is
# our best proxy for ensuring that any test target depending on this target will be invalidated
# on changes to those undeclared dependencies.
# NB: 'pants_run_integration_test.py' runs ./pants in a subprocess using the PYTHONPATH
# of the testrunner. We include the pants binary itself to fully populate the path.
'src/python/pants/bin:pants_local_binary',
'src/rust/engine',
],
)

Expand Down
10 changes: 0 additions & 10 deletions src/rust/engine/BUILD

This file was deleted.

0 comments on commit e543e33

Please sign in to comment.